linux-kernel - Re: 2.6.26-rc5-mm1: uml link error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 11 Jun 2008 14:38:36 +0200
From:	Miklos Szeredi <miklos@...redi.hu>
To:	peter.oberparleiter@...ibm.com
CC:	sam@...nborg.org, oberparleiter@...glemail.com, miklos@...redi.hu,
	jdike@...toit.com, akpm@...uxfoundation.org,
	linux-kernel@...r.kernel.org, rusty@...tcorp.com.au
Subject: Re: 2.6.26-rc5-mm1: uml link error

> Agreed. In that case the SORT(CONSTRUCTORS) statement in
> arch/um/kernel/dyn.lds.S needs to be changed as well though (see my
> previous patch in this thread) or we get the linker error detailed
> in the original post.
> 
> > And we could get away with some flag or something where we 
> > call the constructors.
> 
> The decision whether constructors should be called or not is made at
> configuratiom time - I don't see a variable fitting into this scheme.
> The only alternative I could imagine would be to introduce a hidden
> config symbol CONFIG_CTORS which would be auto-selected by all archs
> except for uml.
> 
> > And a comment explaning why UML is different is also missing.
> 
> Done. Here comes the modifed patch: applies on top of
> kernel-call-constructors.patch, together with the remove-sort-
> construct patch:

With both patches applied builds and boots fine.  Thanks.

> --
> kernel: disable constructor calling for uml
> 
> From: Peter Oberparleiter <peter.oberparleiter@...ibm.com>
> 
> Disable calling of constructor functions for uml as they are already
> called by the host run-time environment.
> 
> Found-by: Miklos Szeredi <miklos@...redi.hu>

I believe the usual form is "Reported-by:".

Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/