linux-kernel - Re: [patch 16/47] bluetooth: fix locking bug in the rfcomm socket cleanup handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 14 Jun 2008 14:26:26 +0200
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Dave Young <hidave.darkstar@...il.com>
Cc:	Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	stable@...nel.org, Justin Forbes <jmforbes@...uxtx.org>,
	Zwane Mwaikambo <zwane@....linux.org.uk>,
	Theodore Ts'o <tytso@....edu>,
	Randy Dunlap <rdunlap@...otime.net>,
	Dave Jones <davej@...hat.com>,
	Chuck Wolber <chuckw@...ntumlinux.com>,
	Chris Wedgwood <reviews@...cw.f00f.org>,
	Michael Krufky <mkrufky@...uxtv.org>,
	Chuck Ebbert <cebbert@...hat.com>,
	Domenico Andreoli <cavokz@...il.com>, Willy Tarreau <w@....eu>,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	alan@...rguk.ukuu.org.uk, Arjan van de Ven <arjan@...ux.intel.com>,
	"David S. Miller" <davem@...emloft.net>,
	Chris Wright <chrisw@...s-sol.org>
Subject: Re: [patch 16/47] bluetooth: fix locking bug in the rfcomm socket
	cleanup handling

Hi Dave,

> > Signed-off-by: Arjan van de Ven <arjan@...ux.intel.com>
> > Acked-by: Marcel Holtmann <marcel@...tmann.org>
> > Signed-off-by: David S. Miller <davem@...emloft.net>
> > Signed-off-by: Chris Wright <chrisw@...s-sol.org>
> > ---
> >  net/bluetooth/rfcomm/core.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- a/net/bluetooth/rfcomm/core.c
> > +++ b/net/bluetooth/rfcomm/core.c
> > @@ -423,8 +423,8 @@ static int __rfcomm_dlc_close(struct rfc
> >
> >                rfcomm_dlc_lock(d);
> >                d->state = BT_CLOSED;
> > -               rfcomm_dlc_unlock(d);
> >                d->state_change(d, err);
> > +               rfcomm_dlc_unlock(d);
> >
> >                skb_queue_purge(&d->tx_queue);
> >                rfcomm_dlc_unlink(d);

did we screw up the tabs during the review process here.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/