linux-kernel - Re: [PATCH 7/8] x86 boot: show pfn addresses in hex not decimal in some kernel info printks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 Jun 2008 00:05:23 -0700
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	"Paul Jackson" <pj@....com>
Cc:	"Ingo Molnar" <mingo@...e.hu>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"Jack Steiner" <steiner@....com>, "Mike Travis" <travis@....com>,
	"H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org,
	"Huang, Ying" <ying.huang@...el.com>,
	"Andi Kleen" <andi@...stfloor.org>,
	"Andrew Morton" <akpm@...ux-foundation.org>
Subject: Re: [PATCH 7/8] x86 boot: show pfn addresses in hex not decimal in some kernel info printks

On Sun, Jun 15, 2008 at 11:30 PM, Paul Jackson <pj@....com> wrote:
> From: Paul Jackson <pj@....com>
>
> Page frame numbers (the portion of physical addresses above the low
> order page offsets) are displayed in several kernel debug and info
> prints in decimal, not hex.  Decimal addresse are unreadable.  Use hex.
>
> Signed-off-by: Paul Jackson <pj@....com>
>
> ---
>  arch/x86/kernel/e820.c |    2 +-
>  mm/page_alloc.c        |   12 ++++++------
>  2 files changed, 7 insertions(+), 7 deletions(-)
>
> --- linux.orig/arch/x86/kernel/e820.c   2008-06-15 21:51:59.643086905 -0700
> +++ linux/arch/x86/kernel/e820.c        2008-06-15 21:51:59.787095630 -0700
> @@ -816,7 +816,7 @@ unsigned long __init e820_end_of_ram(voi
>        if (last_pfn > end_user_pfn)
>                last_pfn = end_user_pfn;
>
> -       printk(KERN_INFO "last_pfn = %lu max_arch_pfn = %lu\n",
> +       printk(KERN_INFO "last_pfn = 0x%lx max_arch_pfn = 0x%lx\n",
>                         last_pfn, max_arch_pfn);
>        return last_pfn;
>  }
> --- linux.orig/mm/page_alloc.c  2008-06-15 21:51:56.890920168 -0700
> +++ linux/mm/page_alloc.c       2008-06-15 21:57:04.525557420 -0700
> @@ -529,7 +529,7 @@ static void __free_pages_ok(struct page
>        int i;
>        int reserved = 0;
>
> -       trace_mark(mm_page_free, "order %u pfn %lu",
> +       trace_mark(mm_page_free, "order %u pfn 0x%lx",
>                order, page_to_pfn(page));
>
>        for (i = 0 ; i < (1 << order) ; ++i)
> @@ -998,7 +998,7 @@ static void free_hot_cold_page(struct pa
>        struct per_cpu_pages *pcp;
>        unsigned long flags;
>
> -       trace_mark(mm_page_free, "order %u pfn %lu", 0, page_to_pfn(page));
> +       trace_mark(mm_page_free, "order %u pfn 0x%lx", 0, page_to_pfn(page));
>
>        if (PageAnon(page))
>                page->mapping = NULL;
> @@ -1665,7 +1665,7 @@ nopage:
>        }
>  got_pg:
>        if (page)
> -               trace_mark(mm_page_alloc, "order %u pfn %lu", order,
> +               trace_mark(mm_page_alloc, "order %u pfn 0x%lx", order,
>                           page_to_pfn(page));
>        return page;
>  }
> @@ -3546,7 +3546,7 @@ void __init add_active_range(unsigned in
>  {
>        int i;
>
> -       printk(KERN_DEBUG "Entering add_active_range(%d, %lu, %lu) "
> +       printk(KERN_DEBUG "Entering add_active_range(%d, 0x%lx, 0x%lx) "
>                          "%d entries of %d used\n",
>                          nid, start_pfn, end_pfn,
>                          nr_nodemap_entries, MAX_ACTIVE_REGIONS);
> @@ -3945,7 +3945,7 @@ void __init free_area_init_nodes(unsigne
>        for (i = 0; i < MAX_NR_ZONES; i++) {
>                if (i == ZONE_MOVABLE)
>                        continue;
> -               printk("  %-8s %8lu -> %8lu\n",
> +               printk("  %-8s 0x%8lx -> 0x%8lx\n",
>                                zone_names[i],
>                                arch_zone_lowest_possible_pfn[i],
>                                arch_zone_highest_possible_pfn[i]);
> @@ -3961,7 +3961,7 @@ void __init free_area_init_nodes(unsigne
>        /* Print out the early_node_map[] */
>        printk("early_node_map[%d] active PFN ranges\n", nr_nodemap_entries);
>        for (i = 0; i < nr_nodemap_entries; i++)
> -               printk("  %3d: %8lu -> %8lu\n", early_node_map[i].nid,
> +               printk("  %3d: 0x%8lx -> 0x%8lx\n", early_node_map[i].nid,
>                                                early_node_map[i].start_pfn,
>                                                early_node_map[i].end_pfn);
>

wonder if we need 0x?

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/