linux-kernel - Re: [RFC/PATCH] ipg: add jumbo frame support kconfig option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 Jun 2008 10:37:36 +0400
From:	Andrew Savchenko <Bircoph@...t.ru>
To:	linux-kernel@...r.kernel.org
Cc:	penberg@...helsinki.fi
Subject: Re: [RFC/PATCH] ipg: add jumbo frame support kconfig option

Hello,

On Wed, 27 Feb 2008 09:44:44 +0200 (EET), Pekka J Enberg wrote:
> Stephen Hemminger wrote:
> > > Please don't do this as a config option. Config options seem
> > > like a good idea to developers but are difficult for
> > > distributions.  Either support jumbo frames by default or
> > > not at all.
>
> On Tue, 26 Feb 2008, Jeff Garzik wrote:
> > Agreed, but to be more specific... always compile in jumbo
> > frame support. You don't have to enable it at runtime by
> > default, though.
>
> Ok, so a sysfs attribute would be sufficient, I suppose? I don't
> have the hardware though, so I don't even know if the jumbo
> frame code actually works at this point hence the RFC. So I'll
> wait for someone to test this before sending a new patch. Thanks
> for the review!

I own such card:
02:02.0 Ethernet controller: Sundance Technology Inc / IC Plus Corp 
IP1000 Family Gigabit Ethernet (rev 41)
and I use patch similar to yours in order to enable Jumbo Frames. 
See attachment for details, patch is done for linux-2.6.25.6.

It works fine for me. However, I enabled 10K jumbo boxes instead of 
default 4K value, activated using your patch. Reason is simple: I 
need at least 9000-byte jumbo boxes in my network.

However, I have one request for you: please, make in possible to 
choose max MTU via kernel config option. In different environments 
different people may need different max MTU sizes (2K...10K). 
Recommended value is 4K (as described in the original driver from 
manufacturer, which was remake into kernel's one), but, for 
example, I'm interested in larger MTU values. OTOH larger MTU 
values require more memory and so on. For me, as for end user of 
Linux kernel, a possibility to select desired max MTU is very 
attractive and is definitely in no doubt more convenient than 
patching the kernel myself each time.

So, feel free to add jumbo boxes on ipg support to the mainstream 
and, please, make in possible to select max MTU; 4K as default 
will be fine.

Sincerely yours,
Andrew

View attachment "ipg-jumbo.patch" of type "text/plain" (1198 bytes)

Content of type "application/pgp-signature" skipped