linux-kernel - [PATCH] aio: avoid using queue_delayed_work in aio_kick

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 Jun 2008 09:27:27 +0530
From:	Nikanth Karthikesan <knikanth@...e.de>
To:	linux-aio@...ck.org
Cc:	linux-kernel@...r.kernel.org, Benjamin LaHaise <bcrl@...ck.org>,
	Jeff Moyer <jmoyer@...hat.com>,
	Zach Brown <zach.brown@...cle.com>
Subject: [PATCH] aio: avoid using queue_delayed_work in aio_kick_handler to schedule itself


Avoid using queue_delayed_work in aio_kick_handler() to run itself 
immediately. Instead use aio_run_all_iocbs()

Signed-off-by: Nikanth Karthikesan <knikanth@...e.de>

---

diff --git a/fs/aio.c b/fs/aio.c
index e27f611..7817e8f 100644
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -823,21 +823,13 @@ static void aio_kick_handler(struct work_struct *work)
 	struct kioctx *ctx = container_of(work, struct kioctx, wq.work);
 	mm_segment_t oldfs = get_fs();
 	struct mm_struct *mm;
-	int requeue;
 
 	set_fs(USER_DS);
-	use_mm(ctx->mm);
-	spin_lock_irq(&ctx->ctx_lock);
-	requeue =__aio_run_iocbs(ctx);
 	mm = ctx->mm;
-	spin_unlock_irq(&ctx->ctx_lock);
+	use_mm(mm);
+	aio_run_all_iocbs(ctx);
  	unuse_mm(mm);
 	set_fs(oldfs);
-	/*
-	 * we're in a worker thread already, don't use queue_delayed_work,
-	 */
-	if (requeue)
-		queue_delayed_work(aio_wq, &ctx->wq, 0);
 }
 
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/