linux-kernel - [PATCH v4 4/6] dmaengine: Make DMA Engine menu visible for AVR32 users

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 Jun 2008 15:23:21 +0200
From:	Haavard Skinnemoen <haavard.skinnemoen@...el.com>
To:	Dan Williams <dan.j.williams@...el.com>,
	Pierre Ossman <drzeus-list@...eus.cx>
Cc:	linux-kernel@...r.kernel.org, linux-embedded@...r.kernel.org,
	kernel@...32linux.org, shannon.nelson@...el.com,
	David Brownell <david-b@...bell.net>,
	Haavard Skinnemoen <haavard.skinnemoen@...el.com>,
	Adrian Bunk <bunk@...sta.de>
Subject: [PATCH v4 4/6] dmaengine: Make DMA Engine menu visible for AVR32 users

This makes the DMA Engine menu visible on AVR32 by adding AVR32 to the
(growing) list of architectures DMADEVICES depends on. Though I'd prefer
to remove that whole "depends" line entirely...

The DMADEVICES menu used to be available for all architectures, but at
some point, we started building a huge dependency list with all the
architectures that might have support for this kind of hardware.

According to Dan Williams:

> Adrian had concerns about users enabling NET_DMA when the hardware
> capability is relatively rare.

which seems very strange as long as (PCI && X86) is enough to enable
this menu. In other words, the vast majority of users will see the menu
even though the hardware is rare.

Also, all DMA clients depend on DMA_ENGINE being set. This symbol is
selected by each DMA Engine driver, so users can't select a DMA client
without selecting a specific DMA Engine driver first.

So, while this patch solves my immediate problem of making DMA Engines
available on AVR32, I'd much rather remove the whole arch dependency
list because I think it's bogus. Comments?

Signed-off-by: Haavard Skinnemoen <haavard.skinnemoen@...el.com>
Cc: Adrian Bunk <bunk@...sta.de>
---
 drivers/dma/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index 18f6ef3..2ac09be 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -4,7 +4,7 @@

 menuconfig DMADEVICES
 	bool "DMA Engine support"
-	depends on (PCI && X86) || ARCH_IOP32X || ARCH_IOP33X || ARCH_IOP13XX || PPC
+	depends on (PCI && X86) || ARCH_IOP32X || ARCH_IOP33X || ARCH_IOP13XX || PPC || AVR32
 	depends on !HIGHMEM64G
 	help
 	  DMA engines can do asynchronous data transfers without
-- 
1.5.5.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/