linux-kernel - Ambiguous dupe in libusual device list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 Jun 2008 13:32:36 -0400
From:	Ben Collins <ben.collins@...onical.com>
To:	usb-storage <usb-storage@...ts.one-eyed-alien.net>
Cc:	kernel list <linux-kernel@...r.kernel.org>
Subject: Ambiguous dupe in libusual device list

In unusual_devs.h, there are these two entries:

#ifdef CONFIG_USB_STORAGE_DATAFAB
/* Submitted by Olaf Hering <olh@...e.de> */
UNUSUAL_DEV(  0x07c4, 0xa109, 0x0000, 0xffff,
                "Datafab Systems, Inc.",
                "USB to CF + SM Combo (LC1)",
                US_SC_SCSI, US_PR_DATAFAB, NULL,
                0 ),
#endif
#ifdef CONFIG_USB_STORAGE_SDDR55
/* SM part - aeb <Andries.Brouwer@....nl> */
UNUSUAL_DEV(  0x07c4, 0xa109, 0x0000, 0xffff,
                "Datafab Systems, Inc.",
                "USB to CF + SM Combo (LC1)",
                US_SC_SCSI, US_PR_SDDR55, NULL,
                US_FL_SINGLE_LUN ),
#endif

If I'm not mistaken (and because libusual is pretty well abstracted, I
might be) this is an ambiguous dupe that isn't resolved with any
checking (IOW, the second entry is likely never used), at least when
both config options are enabled.

If that's not the case, then maybe a comment would be in order? If the
case is that these two options should not be enabled at the same time,
then perhaps some Kconfig magic is required.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/