linux-kernel - Re: [PATCH 2/3] mmc: Export ios settings for a host through debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 28 Jun 2008 09:43:43 -0700
From:	Greg KH <greg@...ah.com>
To:	Haavard Skinnemoen <haavard.skinnemoen@...el.com>
Cc:	Pierre Ossman <drzeus-mmc@...eus.cx>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] mmc: Export ios settings for a host through debugfs

On Sat, Jun 28, 2008 at 06:37:36PM +0200, Haavard Skinnemoen wrote:
> Haavard Skinnemoen <haavard.skinnemoen@...el.com> wrote:
> > Ok, I'll try. I'm not an FS developer, so I'm sure the below patch is
> > horribly broken in some subtle way, but it does appear to work at least
> > the few times I tried it...
> > 
> > Lockdep indeed confirms that something is broken:
> 
> Another try. This time I'm taking only one lock at a time, so lockdep
> is happy. Is it still safe?

At first glance, this looks sane, thanks a lot.

> From ee72de0df9a471eb7fbab7827606a2b9a6afe19c Mon Sep 17 00:00:00 2001
> From: Haavard Skinnemoen <haavard.skinnemoen@...el.com>
> Date: Sat, 28 Jun 2008 17:54:15 +0200
> Subject: [PATCH] debugfs: Implement debugfs_remove_recursive()
> 
> debugfs_remove_recursive() will remove a dentry and all its children.
> Drivers can use this to zap their whole debugfs tree so that they don't
> need to keep track of every single debugfs dentry they created.
> 
> It may fail to remove the whole tree in certain cases:
> 
> sh-3.2# rmmod atmel-mci < /sys/kernel/debug/mmc0/ios/clock
> mmc0: card b368 removed
> atmel_mci atmel_mci.0: Lost dma0chan1, falling back to PIO
> sh-3.2# ls /sys/kernel/debug/mmc0/
> ios
> 
> But I'm not sure if that case can be handled in any sane manner.

I think we have always been failing this case as I know securityfs also
has this same issue, and the code base is pretty much identical.

So don't worry that this patch caused this issue.

I'll queue it up unless there are any other objections to it.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/