[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 28 Jun 2008 13:22:47 +0900
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To: Balbir Singh <balbir@...ux.vnet.ibm.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
YAMAMOTO Takashi <yamamoto@...inux.co.jp>,
Paul Menage <menage@...gle.com>, linux-kernel@...r.kernel.org,
linux-mm@...ck.org
Subject: Re: [RFC 5/5] Memory controller soft limit reclaim on contention
On Fri, 27 Jun 2008 20:49:06 +0530
Balbir Singh <balbir@...ux.vnet.ibm.com> wrote:
> +
> + while (count-- &&
> + ((mem = heap_delete_max(&mem_cgroup_heap)) != NULL)) {
> + BUG_ON(!mem->on_heap);
> + spin_unlock_irqrestore(&mem_cgroup_heap_lock, flags);
> + nr_reclaimed += try_to_free_mem_cgroup_pages(mem,
> + gfp_mask);
> + cond_resched();
> + spin_lock_irqsave(&mem_cgroup_heap_lock, flags);
> + mem->on_heap = 0;
It seems "mem* is not on heap after heap_delete_max(), right ?
If so, I think this on_heap should be cleared right after heap_delete_max().
> + /*
> + * What should be the basis of breaking out?
> + */
> + if (nr_reclaimed)
> + goto done;
why stops here ?
Thanks,
-Kame
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists