linux-kernel - Re: [PATCH] add Sensoray 2255 v4l driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 28 Jun 2008 08:31:54 -0300
From:	Mauro Carvalho Chehab <mchehab@...radead.org>
To:	Greg KH <greg@...ah.com>
Cc:	v4l-dvb-maintainer@...uxtv.org, video4linux-list@...hat.com,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	dean@...soray.com
Subject: Re: [PATCH] add Sensoray 2255 v4l driver

On Thu, 26 Jun 2008 16:15:51 -0700
Greg KH <greg@...ah.com> wrote:

> From: Dean Anderson <dean@...soray.com>
> 
> This driver adds support for the Sensoray 2255 devices.
> 
> It was primarily developed by Dean Anderson with only a little bit of
> guidance and cleanup by Greg.
> 

Hmm... there are still a few minor CodingStyle errors:

ERROR: return is not a function, parentheses are not required
#881: FILE: drivers/media/video/s2255drv.c:792:
+       return (dev->resources[fh->channel]);

WARNING: line over 80 characters
#898: FILE: drivers/media/video/s2255drv.c:809:
+       strlcpy(cap->bus_info, dev_name(&dev->udev->dev), sizeof(cap->bus_info));

ERROR: return is not a function, parentheses are not required
#932: FILE: drivers/media/video/s2255drv.c:843:
+       return (0);

ERROR: return is not a function, parentheses are not required
#1053: FILE: drivers/media/video/s2255drv.c:964:
+               return (ret);

ERROR: return is not a function, parentheses are not required
#1428: FILE: drivers/media/video/s2255drv.c:1339:
+       return (0);

ERROR: return is not a function, parentheses are not required
#1452: FILE: drivers/media/video/s2255drv.c:1363:
+                       return (0);

ERROR: return is not a function, parentheses are not required
#1467: FILE: drivers/media/video/s2255drv.c:1378:
+                       return (0);

ERROR: return is not a function, parentheses are not required
#1487: FILE: drivers/media/video/s2255drv.c:1398:
+                               return (-ERANGE);

total: 7 errors, 1 warnings, 2508 lines checked

I'm applying the patch right now on my tree.

Dean,

When you have some time, please send me a patch fixing those.

heers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/