linux-kernel - Re: [PATCH 1/4] security: filesystem capabilities bugfix1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 Jun 2008 14:15:11 +0100
From:	David Howells <dhowells@...hat.com>
To:	"Andrew G. Morgan" <morgan@...nel.org>
Cc:	dhowells@...hat.com, Andrew Morton <akpm@...ux-foundation.org>,
	"Serge E. Hallyn" <serue@...ibm.com>,
	lkml <linux-kernel@...r.kernel.org>,
	Linux Security Modules List 
	<linux-security-module@...r.kernel.org>
Subject: Re: [PATCH 1/4] security: filesystem capabilities bugfix1

Andrew G. Morgan <morgan@...nel.org> wrote:

> +kernel_cap_t cap_set_effective(const kernel_cap_t pE_new)

Hmmm... kernel_cap_t is a structure that might not fit into a single register.
It occurs to me that you might be better off returing the old caps through a
pointer argument.  It should still work, though.

The SElinux and syscalls LTP testscripts work okay for these patches when
ported to linux-next.  The filecaps LTP testscript can't be used on Fedora 9
as the setcap command is used incorrectly.

Acked-by: David Howells <dhowells@...hat.com>

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/