linux-kernel - Re: [patch 2.6.26-rc8+] mtd: dataflash OTP support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 29 Jun 2008 22:03:14 -0700
From:	David Brownell <david-b@...bell.net>
To:	"Kyungmin Park" <kmpark@...radead.org>
Cc:	"Bryan Wu" <cooloney@...nel.org>,
	"Michael Hennerich" <michael.hennerich@...log.com>,
	linux-mtd@...ts.infradead.org, lkml <linux-kernel@...r.kernel.org>
Subject: Re: [patch 2.6.26-rc8+] mtd: dataflash OTP support

On Sunday 29 June 2008, Kyungmin Park wrote:
> > +#ifdef CONFIG_MTD_OTP
> > +#define HAVE_OTP
> > +#endif
> > +
> > +#ifdef CONFIG_MTD_ONENAND_OTP
> > +#define HAVE_OTP
> > +#endif
> > +
> > +#ifdef CONFIG_MTD_DATAFLASH_OTP
> > +#define HAVE_OTP
> > +#endif
> > +
> 
> How about to add these at Kconfig like this,
> 
> config MTD_HAVE_OTP
>          bool
>          default n
> 
> and NOR, OneNAND, and DATAFLASH select MTD_HAVE_OTP if OTP support.

Shouldn't it be HAVE_MTD_OTP?

That'd be prettier, yes.  MTD_OTP would have been the obvious
choice for the generic symbol, but that's specific to CFI.
(And for that matter, CFI command set 1 ... I have set 2 chips
that can't yet expose their OTP data!)

I'd rather see that as a separate patch though -- either before
or after this one, I don't much care.

- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/