[<prev] [next>] [<thread-prev] [thread-next>] [month] [year] [list]
Date: Tue, 1 Jul 2008 09:20:31 +0800
From: <JosephChan@....com.tw>
To: <alan@...rguk.ukuu.org.uk>
Subject: RE: [PATCH 7/13] viafb: iface.c, iface.h, ioctl.c, ioctl.h
Alan,
Thanks to remind.
Is it good to add viafb_ , ex: viafb_get_memsize(void)?
It would be great to have your comment. Thanks again.
BRs,
Joseph Chan
-----Original Message-----
From: Alan Cox [mailto:alan@...rguk.ukuu.org.uk]
Sent: Monday, June 30, 2008 5:40 PM
To: Joseph Chan
Cc: Joseph Chan; linux-fbdev-devel@...ts.sourceforge.net; linux-kernel@...r.kernel.org; akpm@...ux-foundation.org; geert@...ux-m68k.org
Subject: Re: [PATCH 7/13] viafb: iface.c, iface.h, ioctl.c, ioctl.h
> +/* Get frame buffer size from VGA BIOS */
> +
> +unsigned int get_memsize(void)
Not a good name for a globally visible function!
> +unsigned long get_videobuf_addr(void) {
Ditto
Hosted by DataForce ISP -
Powered by Openwall GNU/*/Linux