linux-kernel - Re: [PATCH 4/5] MMC: fix spares errors of sdhci.c

lists.openwall.net		lists / announce john-users owl-users popa3d-users / xvendor oss-security / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4
Open Source and information security mailing list archives

This website is powered by Openwall GNU/*/Linux security-enhanced OS

[<prev] [next>] [<thread-prev] [thread-next>] [month] [year] [list]

Date:	Tue, 01 Jul 2008 03:47:38 +0200
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Tomas Winkler <tomas.winkler@...el.com>
Subject: Re: [PATCH 4/5] MMC: fix spares errors of sdhci.c

Hi Tomas,

>  	if (host->flags & SDHCI_REQ_USE_DMA) {
> -		int count;
> +		int dma_cnt;
>  
> -		count = dma_map_sg(mmc_dev(host->mmc), data->sg, data->sg_len,
> +		dma_cnt = dma_map_sg(mmc_dev(host->mmc), data->sg, data->sg_len,
>  				(data->flags & MMC_DATA_READ) ?
>  					DMA_FROM_DEVICE : DMA_TO_DEVICE);
> -		WARN_ON(count != 1);
> +		WARN_ON(dma_cnt != 1);

can you include what sparse error this is trying to fix. From the patch
itself, I can't see it.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/