linux-kernel - RE: [PATCH] HP iLO driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 1 Jul 2008 21:01:01 +0000
From:	"Altobelli, David" <david.altobelli@...com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] HP iLO driver

Andrew Morton wrote:
>
> Doing a GFP_KERNEL allocation inside spin_lock() is a flagrant bug
> which would have been detected had you enabled
> CONFIG_DEBUG_SPINLOCK_SLEEP (which ia64 appears to support (if this is
> an ia64-only driver?)) while testing.
>
> Please see Documentation/SubmitChecklist

Oops, sorry.  Right now, this is basically an x86 only driver.

> Using GFP_ATOMIC would be a poor solution for this - it is unreliable.
> Better would be to speculatively perform the allocation outside the
> spinlocked region and then toss it away if you didn't use it:

Will do.

> OK, so this is available on all architectures?
>
> There are pros and cons.  No avr32 user is likely to use this driver
> ;), but otoh having it compiled on other architectures can expose
> problems.

My hope was to write code that would work across architectures,
but the device is currently shipped only on x86.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/