linux-kernel - Re: [PATCH 01/04] s390: bus_id -> dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 3 Jul 2008 17:18:44 +0200
From:	Heiko Carstens <heiko.carstens@...ibm.com>
To:	Greg KH <greg@...ah.com>
Cc:	Cornelia Huck <cornelia.huck@...ibm.com>, schwidefsky@...ibm.com,
	linux390@...ibm.com, Kay Sievers <kay.sievers@...y.org>,
	linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/04] s390: bus_id -> dev_name conversions

On Wed, Jul 02, 2008 at 11:49:43AM -0700, Greg KH wrote:
> On Wed, Jul 02, 2008 at 06:28:32PM +0200, Cornelia Huck wrote:
> > On Wed, 2 Jul 2008 08:46:30 -0700,
> > Greg KH <greg@...ah.com> wrote:
> > 
> > > @@ -529,7 +529,7 @@ cio_validate_subchannel (struct subchann
> > >  	}
> > >  	mutex_init(&sch->reg_mutex);
> > >  	/* Set a name for the subchannel */
> > > -	snprintf (sch->dev.bus_id, BUS_ID_SIZE, "0.%x.%04x", schid.ssid,
> > > +	snprintf (dev_name(&sch->dev), BUS_ID_SIZE, "0.%x.%04x", schid.ssid,
> > >  		  schid.sch_no);
> > > 
> > >  	/*
> > 
> > This hunk does not make much sense. Better just leave it alone until
> > the dev_set_name()/init_name conversion later.
> 
> You are right.
> 
> 390 maintainers, can you drop this hunk, or do you want me to respin it
> and the other 3 patches (if needed)?

Please resend, since patch 2 needs to be changed as well, right?

Thanks! :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/