linux-kernel - Re: linux-next: 1ea0704e (ptep_modify_prot transaction abstraction) breaks no-mmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 03 Jul 2008 08:53:52 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Mike Frysinger <vapier.adi@...il.com>
CC:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: 1ea0704e (ptep_modify_prot transaction abstraction)
 breaks no-mmu

Mike Frysinger wrote:
> the functions added to asm-generic/pgtable.h are only used by
> mm/mprotect.c (a MMU-only file), but they were not added inside of the
> CONFIG_MMU ifdef block.  since the functions rely on things inside of
> CONFIG_MMU (the lines just above in pgtable.h), we get build failure
> on all no-mmu setups:
>   CC      init/main.o
> In file included from include/asm/pgtable.h:94,
>                  from include/linux/mm.h:39,
>                  from include/asm/dma.h:39,
>                  from include/linux/bootmem.h:8,
>                  from init/main.c:27:
> include/asm-generic/pgtable.h: In function '__ptep_modify_prot_start':
> include/asm-generic/pgtable.h:210: error: implicit declaration of
> function 'ptep_get_and_clear'
> include/asm-generic/pgtable.h:210: error: incompatible types in return
> make[1]: *** [init/main.o] Error 1
> make: *** [init/main.o] Error 2
> -mike
>   

Uh, OK.  What does mprotect do on a nommu system?  Would it be 
sufficient to move the definitions of __ptep_modify_prot_start/commit 
out of a CONFIG_MMU block, or provide separate no-op versions?

    J

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/