linux-kernel - Re: [PATCH] x86 ptrace: fix PTRACE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 03 Jul 2008 11:37:41 +0900 (JST)
From:	TAKADA Yoshihito <takada@....nifty.com>
To:	mingo@...e.hu
Cc:	roland@...hat.com, tglx@...utronix.de,
	linux-kernel@...r.kernel.org, stable@...nel.org
Subject: Re: [PATCH] x86 ptrace: fix PTRACE_GETFPXREGS error

Hi.
The Roland's patch is bettor than mine.
Please apply Roland's only. Don't apply both. Either is enough.


From: Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH] x86 ptrace: fix PTRACE_GETFPXREGS error
Date: Tue, 1 Jul 2008 11:02:04 +0200

> 
> * Roland McGrath <roland@...hat.com> wrote:
> 
> > ptrace has always returned only -EIO for all failures to access 
> > registers.  The user_regset calls are allowed to return a more 
> > meaningful variety of errors.  The REGSET_XFP calls use -ENODEV for 
> > !cpu_has_fxsr hardware.  Make ptrace return the traditional -EIO 
> > instead of the error code from the user_regset call.
> 
> since the original fix is already upstream, i've applied the delta patch 
> below. Should we still do this for v2.6.26 or can we defer it to 
> v2.6.27? As ptrace is the only user of this facility for now this would 
> be an identity transformation AFAICS and the v2.6.26 release is very 
> close.
> 
> 	Ingo
> 
> ---------------->
> Subject: x86 ptrace: fix PTRACE_GETFPXREGS error
> From: Roland McGrath <roland@...hat.com>
> Date: Mon, 30 Jun 2008 14:02:41 -0700 (PDT)
> 
> ptrace has always returned only -EIO for all failures to access
> registers.  The user_regset calls are allowed to return a more
> meaningful variety of errors.  The REGSET_XFP calls use -ENODEV
> for !cpu_has_fxsr hardware.  Make ptrace return the traditional
> -EIO instead of the error code from the user_regset call.
> 
> Signed-off-by: Roland McGrath <roland@...hat.com>
> Cc: stable@...nel.org
> Signed-off-by: Ingo Molnar <mingo@...e.hu>
> ---
>  arch/x86/kernel/i387.c   |    4 ++--
>  arch/x86/kernel/ptrace.c |    4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> Index: tip/arch/x86/kernel/i387.c
> ===================================================================
> --- tip.orig/arch/x86/kernel/i387.c
> +++ tip/arch/x86/kernel/i387.c
> @@ -162,7 +162,7 @@ int xfpregs_get(struct task_struct *targ
>  	int ret;
>  
>  	if (!cpu_has_fxsr)
> -		return -EIO;
> +		return -ENODEV;
>  
>  	ret = init_fpu(target);
>  	if (ret)
> @@ -179,7 +179,7 @@ int xfpregs_set(struct task_struct *targ
>  	int ret;
>  
>  	if (!cpu_has_fxsr)
> -		return -EIO;
> +		return -ENODEV;
>  
>  	ret = init_fpu(target);
>  	if (ret)
> Index: tip/arch/x86/kernel/ptrace.c
> ===================================================================
> --- tip.orig/arch/x86/kernel/ptrace.c
> +++ tip/arch/x86/kernel/ptrace.c
> @@ -943,13 +943,13 @@ long arch_ptrace(struct task_struct *chi
>  		return copy_regset_to_user(child, &user_x86_32_view,
>  					   REGSET_XFP,
>  					   0, sizeof(struct user_fxsr_struct),
> -					   datap);
> +					   datap) ? -EIO : 0;
>  
>  	case PTRACE_SETFPXREGS:	/* Set the child extended FPU state. */
>  		return copy_regset_from_user(child, &user_x86_32_view,
>  					     REGSET_XFP,
>  					     0, sizeof(struct user_fxsr_struct),
> -					     datap);
> +					     datap) ? -EIO : 0;
>  #endif
>  
>  #if defined CONFIG_X86_32 || defined CONFIG_IA32_EMULATION
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/