linux-kernel - Re: [BUGFIX][PATCH] configfs: Fix open directory making rmdir() fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 3 Jul 2008 15:08:05 -0700
From:	Joel Becker <Joel.Becker@...cle.com>
To:	Louis Rilling <louis.rilling@...labs.com>
Cc:	linux-kernel@...r.kernel.org, ocfs2-devel@....oracle.com
Subject: Re: [BUGFIX][PATCH] configfs: Fix open directory making rmdir()
	fail

On Fri, Jun 27, 2008 at 01:10:25PM +0200, Louis Rilling wrote:
> When checking for user-created elements under an item to be removed by rmdir(),
> configfs_detach_prep() counts fake configfs_dirents created by dir_open() as
> user-created and fails when finding one. It is however perfectly valid to remove
> a directory that is open.
> 
> Simply make configfs_detach_prep() skip fake configfs_dirent, like it already
> does for attributes, and like detach_groups() does.

	This looks good.

> Signed-off-by: Louis Rilling <louis.rilling@...labs.com>
> ---
>  fs/configfs/dir.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c
> index 2c873fd..e721fd5 100644
> --- a/fs/configfs/dir.c
> +++ b/fs/configfs/dir.c
> @@ -379,7 +379,8 @@ static int configfs_detach_prep(struct dentry *dentry, struct mutex **wait_mutex
>  
>  	ret = 0;
>  	list_for_each_entry(sd, &parent_sd->s_children, s_sibling) {
> -		if (sd->s_type & CONFIGFS_NOT_PINNED)
> +		if (!sd->s_element ||
> +		    (sd->s_type & CONFIGFS_NOT_PINNED))
>  			continue;
>  		if (sd->s_type & CONFIGFS_USET_DEFAULT) {
>  			/* Abort if racing with mkdir() */
> -- 
> 1.5.5.3
> 

-- 

"You can get more with a kind word and a gun than you can with
 a kind word alone."
         - Al Capone

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@...cle.com
Phone: (650) 506-8127
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/