linux-kernel - Re: [PATCH] advansys: use request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Jul 2008 07:56:44 -0700
From:	David Woodhouse <dwmw2@...radead.org>
To:	Matthew Wilcox <matthew@....cx>
Cc:	Jaswinder Singh <jaswinder@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	kernel-janitors <kernel-janitors@...r.kernel.org>,
	kernelnewbies <kernelnewbies@...linux.org>,
	linux-scsi@...r.kernel.org, hch@...radead.org
Subject: Re: [PATCH] advansys: use request_firmware

On Mon, 2008-07-14 at 08:50 -0600, Matthew Wilcox wrote:
> I'm not quite sure whether my question was answered ...
> 
> When firmware is built in, does
> 1) request_firmware() make a copy of it and then release_firmware free
>    that copy?
> 2) request_firmware() return a pointer to the built-in firmware with
>    release_firmware() being a no-op?
> 3) request_firmware() return a pointer to the built-in firmware with
>    release_firmware() freeing the original?
> 
> Cases 1 and 2 are fine, case 3 is a problem.

Effectively (2).

Actually we do allocate and free the 'struct firmware' but fw->data is
just pointed to the original blob, and then that blob doesn't get freed.

-- 
dwmw2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/