| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 18 Jul 2008 13:07:58 -0700 From: ebiederm@...ssion.com (Eric W. Biederman) To: WANG Cong <xiyou.wangcong@...il.com> Cc: LKML <linux-kernel@...r.kernel.org>, kexec@...ts.infradead.org Subject: Re: [Patch] kexec: remove redundant if-else WANG Cong <xiyou.wangcong@...il.com> writes: > These if-else's can be removed. Why? That appears to be pointless code style thrashing. Converting code with a single return into code with multiple returns. Which arguably makes it harder to prove properties about. Further if you want to use the style you suggest a label name like err is better than the name out. But in this case where we have multiple results I don't like the proposed change in style at all. Especially with no rational. Eric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists