linux-kernel - Re: linux-next: Tree for July 18: warning at kernel/lockdep.c:2068 trace_hardirqs_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 20 Jul 2008 01:11:36 +0200
From:	"Vegard Nossum" <vegard.nossum@...il.com>
To:	"Greg KH" <gregkh@...e.de>
Cc:	"Mariusz Kozlowski" <m.kozlowski@...land.pl>,
	"Dave Hansen" <haveblue@...ibm.com>,
	"Stephen Rothwell" <sfr@...b.auug.org.au>,
	kernel-testers@...r.kernel.org, linux-next@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	"Pekka Enberg" <penberg@...helsinki.fi>,
	"Bernhard Walle" <bwalle@...e.de>, "Ingo Molnar" <mingo@...e.hu>,
	"Vivek Goyal" <vgoyal@...hat.com>
Subject: Re: linux-next: Tree for July 18: warning at kernel/lockdep.c:2068 trace_hardirqs_on_caller

On Sun, Jul 20, 2008 at 12:58 AM, Greg KH <gregkh@...e.de> wrote:
>> firmware_map_add_early() is using bootmem for the allocation. So yes,
>> I guess it should possible to use kobjects here. That said, this code
>> is in fact fairly recent:
>>
>> commit 69ac9cd629ca96e59f34eb4ccd12d00b2c8276a7
>> Author: Bernhard Walle <bwalle@...e.de>
>> Date:   Fri Jun 27 13:12:54 2008 +0200
>>
>>     sysfs: add /sys/firmware/memmap
>>
>> I'll add the Cc. I still have a feeling that the kobject patch should
>> expect to run even when slab is not available.
>
> I never has been expected to do so in the past, so odds are, lots of
> things might break :(

Yeah. Maybe you should withdraw your ack? :-D

    Signed-off-by: Bernhard Walle <bwalle@...e.de>
    Acked-by: Greg KH <gregkh@...e.de>
    Acked-by: Vivek Goyal <vgoyal@...hat.com>
    Cc: kexec@...ts.infradead.org
    Cc: yhlu.kernel@...il.com
    Signed-off-by: Ingo Molnar <mingo@...e.hu>

I'm sorry for having been a bit rash earlier -- it's the combination
of the patches that produce the failure; they both seem okay on their
own. On the other hand, this is what -next is for, isn't it?

Maybe the firmware memmap code can simply run a little later in the
boot sequence?


Vegard

-- 
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
	-- E. W. Dijkstra, EWD1036
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/