linux-kernel - [RFC] breakage in bsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 20 Jul 2008 17:34:06 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Jens Axboe <jens.axboe@...cle.com>
Cc:	pjones@...hat.com, FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	linux-kernel@...r.kernel.org
Subject: [RFC] breakage in bsg

	* with "bsg: bind bsg to request_queue instead of gendisk" we
get all requests with NULL ->rq_disk.  SCSI can cope with that, anything
else is not promised to be able to surive that.  Indeed, quite a few
drivers do not.

	* WTF are these per-bd flags doing, seeing that you set them
on every ->read() and ->write()?  Just what will happen if you have
two openers?

	* cmd_filter thing is broken as well (we have no access to
gendisk in question and there's a lot of obvious issues when you have
several openers).

#2 and part of #3 are fixable, but I really don't see what to do with #1.
If nothing else, it's absolutely incompatible with cmd_filter, even if you
leave aside the issue with non-IDE/non-SCSI drivers.

Comments?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/