linux-kernel - Re: [PATCH] x86-rest: fix sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 21 Jul 2008 13:24:53 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jaswinder Singh <jaswinder@...radead.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	kernelnewbies <kernelnewbies@...linux.org>,
	kernel-janitors <kernel-janitors@...r.kernel.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] x86-rest: fix sparse warnings


* Jaswinder Singh <jaswinder@...radead.org> wrote:

> CHECK   arch/x86/mm/init_32.c
> arch/x86/mm/init_32.c:290:13: warning: symbol 'add_one_highpage_init' was not declared. Should it be static?
> arch/x86/mm/init_32.c:437:6: warning: symbol 'zap_low_mappings' was not declared. Should it be static?
> arch/x86/mm/init_32.c:774:6: warning: symbol 'free_initmem' was not declared. Should it be static?
> 
> CHECK   arch/x86/mm/fault.c
> arch/x86/mm/fault.c:581:16: warning: symbol 'do_page_fault' was not declared. Should it be static?
> 
> CHECK   arch/x86/mm/pat.c
> arch/x86/mm/pat.c:566:6: warning: symbol 'map_devmem' was not declared. Should it be static?
> arch/x86/mm/pat.c:583:6: warning: symbol 'unmap_devmem' was not declared. Should it be static?
> 
> CHECK   arch/x86/mm/pgtable_32.c
> arch/x86/mm/pgtable_32.c:115:6: warning: symbol 'set_pmd_pfn' was not declared. Should it be static?
> 
> CHECK   arch/x86/mach-default/setup.c
> arch/x86/mach-default/setup.c:19:5: warning: symbol 'no_broadcast' was not declared. Should it be static?
> 
> Signed-off-by: Jaswinder Singh <jaswinder@...radead.org>
> ---
>  arch/x86/mach-default/setup.c |    2 +-
>  include/asm-x86/pat.h         |    3 +++
>  include/asm-x86/pgtable_32.h  |    6 ++++++
>  include/asm-x86/setup.h       |    1 +
>  4 files changed, 11 insertions(+), 1 deletions(-)

please split this up too into individual commits, against tip/master. 
Cleanups are generally more manageable if they are finegrained.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/