linux-kernel - Re: [PATCH] x86: PIC, L-APIC and I/O APIC debug information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 21 Jul 2008 02:36:40 +0200
From:	Mikael Pettersson <mikpe@...uu.se>
To:	"Maciej W. Rozycki" <macro@...ux-mips.org>
Cc:	Ingo Molnar <mingo@...e.hu>, Chuck Ebbert <cebbert@...hat.com>,
	x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: PIC, L-APIC and I/O APIC debug information

Maciej W. Rozycki writes:
 >  Dump all the PIC, local APIC and I/O APIC information at the
 > fs_initcall() level, which is after ACPI (if used) has initialised PCI
 > information, making the point of invocation consistent across MP-table and
 > ACPI platforms.  Remove explicit calls to print_IO_APIC() from elsewhere.  
 > Make the interface of all the functions involved consistent between 32-bit
 > and 64-bit versions and make them all static by default by the means of a
 > New-and-Improved(TM) __apicdebuginit() macro.
...
 > +#define __apicdebuginit(type) static type __init
...
 > -void __init print_IO_APIC(void)
 > +
 > +__apicdebuginit(void) print_IO_APIC(void)
 >  {

I _really_ dislike how this abuses the C macro preprocessor
to create pointless new syntax.

Since you're editing these function definitions anyway why
not just spell out "static void __init" in readable proper C?

/Mikael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/