linux-kernel - Re: [PATCH -mm] coredump: format_corename: don't append .%pid if multi-threaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 Jul 2008 17:02:06 +0400
From:	Oleg Nesterov <oleg@...sign.ru>
To:	Michael Kerrisk <mtk.manpages@...glemail.com>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Roland McGrath <roland@...hat.com>, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, andi@...stfloor.org
Subject: Re: [PATCH -mm] coredump: format_corename: don't append .%pid if multi-threaded

On 07/22, Michael Kerrisk wrote:
>
> On Tue, Jul 22, 2008 at 2:43 PM, Oleg Nesterov <oleg@...sign.ru> wrote:
> >
> > That said, this is the user-visible change...
>
> True.  Not sure how important that is in this case though.  What is
> the reason for making this change (other than tidiness)?

Tidiness is the only reason.

Please don't hesitate to nack this patch if you think we shouldn't
change the historical behaviour, the cleanup is very minor.

As for me, I think it is a bit strange we append "%.pid" depending on
is_multithreaded, the same app can have 1 or more threads for various
reasons when the coredump happens, but this behaviour is very old and
perhaps it is too late to change.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/