linux-kernel - Re: [PATCH] cifs: avoid mixing bool and le16

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Jul 2008 19:26:47 -0500
From:	"Steve French" <smfrench@...il.com>
To:	"Harvey Harrison" <harvey.harrison@...il.com>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cifs: avoid mixing bool and le16

On Wed, Jul 23, 2008 at 7:24 PM, Harvey Harrison
<harvey.harrison@...il.com> wrote:
> On Wed, 2008-07-23 at 19:19 -0500, Steve French wrote:
> Would you prefer:
>        if (pSMBr->hdr.Flags2 & SMBFLG2_UNICODE)
>                is_unicode = true;
>        else
>                is_unicode = false;
>
> Instead?

Yes   :)



-- 
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/