lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 26 Jul 2008 12:17:16 +0200 From: Ingo Molnar <mingo@...e.hu> To: Robert Richter <robert.richter@....com> Cc: Barry Kasindorf <barry.kasindorf@....com>, Thomas Gleixner <tglx@...utronix.de>, oprofile-list <oprofile-list@...ts.sourceforge.net>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 24/24] x86/oprofile: Reanaming op_model_athlon.c to op_model_amd.c * Robert Richter <robert.richter@....com> wrote: > +#define NUM_COUNTERS 4 > +#define NUM_CONTROLS 4 > + > +#define CTR_IS_RESERVED(msrs, c) (msrs->counters[(c)].addr ? 1 : 0) > +#define CTR_READ(l, h, msrs, c) do {rdmsr(msrs->counters[(c)].addr, (l), (h)); } while (0) > +#define CTR_WRITE(l, msrs, c) do {wrmsr(msrs->counters[(c)].addr, -(unsigned int)(l), -1); } while (0) > +#define CTR_OVERFLOWED(n) (!((n) & (1U<<31))) > + > +#define CTRL_IS_RESERVED(msrs, c) (msrs->controls[(c)].addr ? 1 : 0) > +#define CTRL_READ(l, h, msrs, c) do {rdmsr(msrs->controls[(c)].addr, (l), (h)); } while (0) > +#define CTRL_WRITE(l, h, msrs, c) do {wrmsr(msrs->controls[(c)].addr, (l), (h)); } while (0) > +#define CTRL_SET_ACTIVE(n) (n |= (1<<22)) > +#define CTRL_SET_INACTIVE(n) (n &= ~(1<<22)) > +#define CTRL_CLEAR_LO(x) (x &= (1<<21)) > +#define CTRL_CLEAR_HI(x) (x &= 0xfffffcf0) > +#define CTRL_SET_ENABLE(val) (val |= 1<<20) > +#define CTRL_SET_USR(val, u) (val |= ((u & 1) << 16)) > +#define CTRL_SET_KERN(val, k) (val |= ((k & 1) << 17)) > +#define CTRL_SET_UM(val, m) (val |= (m << 8)) > +#define CTRL_SET_EVENT_LOW(val, e) (val |= (e & 0xff)) > +#define CTRL_SET_EVENT_HIGH(val, e) (val |= ((e >> 8) & 0xf)) > +#define CTRL_SET_HOST_ONLY(val, h) (val |= ((h & 1) << 9)) > +#define CTRL_SET_GUEST_ONLY(val, h) (val |= ((h & 1) << 8)) while at it, it would be nice to have a followup cleanup that aligns these vertically. > +#ifdef CONFIG_OPROFILE_IBS btw., why not include IBS support unconditionally in the _amd.ko module? It's all loadable anyway - and the size difference is small. That would get rid of a ton of #ifdef complexity. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists