linux-kernel - Re: [PATCH 5/6] x86: coding style fixes to arch/x86/kernel/traps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 31 Jul 2008 18:31:50 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	"Gustavo F. Padovan" <gustavo@....ic.unicamp.br>
Cc:	linux-kernel@...r.kernel.org,
	the arch/x86 maintainers <x86@...nel.org>
Subject: Re: [PATCH 5/6] x86: coding style fixes to
	arch/x86/kernel/traps_64.c


* Gustavo F. Padovan <gustavo@....ic.unicamp.br> wrote:

>  void printk_address(unsigned long address, int reliable)
>  {
> -	printk(" [<%016lx>] %s%pS\n", address, reliable ? "": "? ", (void *) address);
> +	printk(" [<%016lx>] %s%pS\n", address, reliable ?
> +			"" : "? ", (void *) address);

careful with line 80 warnings. This one is better broken up the 
following way:

	printk(" [<%016lx>] %s%pS\n",
	       address, reliable ? "": "? ", (void *) address);

so that logically coherent pieces of code stay together. (the arguments 
to the printk() function call in this case)

>  #if DEBUG_STKSZ > EXCEPTION_STKSZ
> -		[N_EXCEPTION_STACKS ... N_EXCEPTION_STACKS + DEBUG_STKSZ / EXCEPTION_STKSZ - 2] = "#DB[?]"
> +		[N_EXCEPTION_STACKS ... N_EXCEPTION_STACKS + DEBUG_STKSZ /
> +			EXCEPTION_STKSZ - 2] = "#DB[?]"

this too is done better in another way:

	[N_EXCEPTION_STACKS ... 
	 N_EXCEPTION_STACKS + DEBUG_STKSZ / EXCEPTION_STKSZ - 2] = "#DB[?]"

> -	// debugging aid: "show_stack(NULL, NULL);" prints the
> -	// back trace for this cpu.
> +	/* debugging aid: "show_stack(NULL, NULL);" prints the
> +	  back trace for this cpu. */

please use the standard multi-line comment format:

	/*
	 * Multi-line ...........
	 * .............. comment.
	 */

i've applied your patches already to x86/cleanups, so please send a 
delta patch against that branch to fix these few items up. You can pick 
it up via:

    http://people.redhat.com/mingo/tip.git/README

and do:

    git-checkout tip/x86/cleanups

to check out that exact tree. (You might also want to work against 
tip/master, which has the same changes.)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/