linux-kernel - Re: [PATCH] ALSA: pcm_native: remove unused label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 3 Aug 2008 19:33:19 +0200 (CEST)
From:	Sven Wegener <sven.wegener@...aler.net>
To:	Marcin Slusarz <marcin.slusarz@...il.com>
cc:	LKML <linux-kernel@...r.kernel.org>, Takashi Iwai <tiwai@...e.de>,
	Jaroslav Kysela <perex@...ex.cz>
Subject: Re: [PATCH] ALSA: pcm_native: remove unused label

On Sun, 3 Aug 2008, Sven Wegener wrote:

> On Sun, 3 Aug 2008, Marcin Slusarz wrote:
> 
> > gcc warns about it:
> > sound/core/pcm_native.c: In function 'snd_pcm_fasync':
> > sound/core/pcm_native.c:3262: warning: label 'out' defined but not used
> > 
> > Signed-off-by: Marcin Slusarz <marcin.slusarz@...il.com>
> > Cc: Takashi Iwai <tiwai@...e.de>
> > Cc: Jaroslav Kysela <perex@...ex.cz>
> > ---
> >  sound/core/pcm_native.c |    1 -
> >  1 files changed, 0 insertions(+), 1 deletions(-)
> > 
> > diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
> > index c49b9d9..333cff6 100644
> > --- a/sound/core/pcm_native.c
> > +++ b/sound/core/pcm_native.c
> > @@ -3259,7 +3259,6 @@ static int snd_pcm_fasync(int fd, struct file * file, int on)
> >  	runtime = substream->runtime;
> >  
> >  	err = fasync_helper(fd, file, on, &runtime->fasync);
> > -out:
> >  	unlock_kernel();
> >  	if (err < 0)
> >  		return err;
> 
> Uhm, no, there's
> 
> snd_assert(substream != NULL, goto out);
> 
> one line above your context.

And that is broken. That's not what an assert is for, we access 
substream->runtime a line later and that will blow up. That should be a 
simpe if, instead of an assert.

Sven
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/