linux-kernel - Re: [regression?] usb: new errors during device detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Aug 2008 10:13:48 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Frans Pop <elendil@...net.nl>
cc:	linux-kernel@...r.kernel.org,
	Kernel Testers List <kernel-testers@...r.kernel.org>,
	<linux-usb@...r.kernel.org>
Subject: Re: [regression?] usb: new errors during device detection

On Sun, 3 Aug 2008, Frans Pop wrote:

> Not sure how I should interpret this difference between dmesg output for
> 2.6.26 and 2.6.27-rc1 (after 'grep -i usb'):
> 
>  usbcore: registered new interface driver usbfs
>  usbcore: registered new interface driver hub
>  usbcore: registered new device driver usb
>  USB Universal Host Controller Interface driver v3.0
>  uhci_hcd 0000:00:1d.0: new USB bus registered, assigned bus number 1
>  usb usb1: configuration #1 chosen from 1 choice
>  hub 1-0:1.0: USB hub found
>  uhci_hcd 0000:00:1d.1: new USB bus registered, assigned bus number 2
>  usb usb2: configuration #1 chosen from 1 choice
>  hub 2-0:1.0: USB hub found
>  uhci_hcd 0000:00:1d.2: new USB bus registered, assigned bus number 3
>  usb usb3: configuration #1 chosen from 1 choice
>  hub 3-0:1.0: USB hub found
>  uhci_hcd 0000:00:1d.3: new USB bus registered, assigned bus number 4
>  usb usb4: configuration #1 chosen from 1 choice
>  hub 4-0:1.0: USB hub found
> +usb 3-1: new low speed USB device using uhci_hcd and address 2
>  ehci_hcd 0000:00:1d.7: new USB bus registered, assigned bus number 5
>  ehci_hcd 0000:00:1d.7: USB 2.0 started, EHCI 1.00, driver 10 Dec 2004
>  usb usb5: configuration #1 chosen from 1 choice
>  hub 5-0:1.0: USB hub found
> -usb 3-1: new low speed USB device using uhci_hcd and address 2
> +usb 3-1: device not accepting address 2, error -71
> +hub 3-0:1.0: unable to enumerate USB device on port 1
> +usb 3-1: new low speed USB device using uhci_hcd and address 4
>  usb 3-1: configuration #1 chosen from 1 choice
>  usb 4-1: new low speed USB device using uhci_hcd and address 2
>  usb 4-1: configuration #1 chosen from 1 choice
>  usbcore: registered new interface driver hiddev
>  input: USB Compliant Keyboard as /class/input/input0
>  input: USB HID v1.10 Keyboard [USB Compliant Keyboard] on usb-0000:00:1d.2-1
>  input: USB Compliant Keyboard as /class/input/input1
>  input: USB HID v1.10 Device [USB Compliant Keyboard] on usb-0000:00:1d.2-1
>  input: Logitech USB Receiver as /class/input/input2
>  input: USB HID v1.10 Mouse [Logitech USB Receiver] on usb-0000:00:1d.3-1
>  usbcore: registered new interface driver usbhid
>  usbhid: v2.6:USB HID core driver

The difference is most likely meaningless; it is probably caused a 
different order of initialization of the EHCI and UHCI controllers.

> Note that 3-1 is first assigned address 2 and then 4. With 2.6.26 3-1 did
> not have any problem accepting address 2. I assume the "unable to enumerate"
> error is a result of the rejection of the address?

No.  It is caused by the EHCI controller being initialized.

When an EHCI controller is initialized, it switches all the USB
connections from its companion controllers to itself.  Hence any device
which _was_ connected to the UHCI controller will _now_ be connected to
the EHCI controller.  Consequently the UHCI controller is unable to
communicate with the device and cannot enumerate it.

After a short time, the EHCI controller driver realizes that the device 
can't run at high speed and switches it back to the UHCI controller.  
At that point it gets enumerated for the second time, successfully.

The difference must have been that under 2.6.26 the EHCI controller was 
initialized _before_ the 3-1 device was detected, so there was no 
aborted attempt at enumeration.

If you want to prevent all errors of this sort, all you have to do is 
insure that ehci-hcd is loaded before either uhci-hcd or ohci-hcd 
during system startup.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/