linux-kernel - Re: [PATCH 21/25] serial: change remove NR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Aug 2008 11:13:36 -0700
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	"Alan Cox" <alan@...rguk.ukuu.org.uk>
Cc:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	"Ingo Molnar" <mingo@...e.hu>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	"Dhaval Giani" <dhaval@...ux.vnet.ibm.com>,
	"Mike Travis" <travis@....com>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 21/25] serial: change remove NR_IRQS in 8250.c v2

On Mon, Aug 4, 2008 at 7:17 AM, Alan Cox <alan@...rguk.ukuu.org.uk> wrote:
>> Would allow us to use the generic hash table code.
>
> Nice.. that makes the code a bit longer in source form but much clearer
> and sharing common design.
>
>> Looks like we can also tweak serial_do_unlink to free irq_info when
>> the list goes empty, so we don't have a leak if the driver is ever
>> unloaded.
>
> Like this (again not yet tested)
>
> 8250: Remove NR_IRQ usage
>
> From: Alan Cox <alan@...hat.com>
>
>
> ---
>
>  drivers/serial/68328serial.c |   11 +------
>  drivers/serial/8250.c        |   68 +++++++++++++++++++++++++++++++++---------
>  2 files changed, 56 insertions(+), 23 deletions(-)
>

thanks. will test it.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/