linux-kernel - Re: [PATCH] iwlwifi: Don't use buffer allocated on the stack for led names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 04 Aug 2008 11:39:30 +0800
From:	Zhu Yi <yi.zhu@...el.com>
To:	Sven Wegener <sven.wegener@...aler.net>
Cc:	Reinette Chatre <reinette.chatre@...el.com>,
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
	Richard Purdie <rpurdie@...ys.net>
Subject: Re: [PATCH] iwlwifi: Don't use buffer allocated on the stack for
	led names

On Fri, 2008-08-01 at 21:57 +0200, Sven Wegener wrote:
> Having the buffer on the stack and even re-using it for all led
> devices is bad.
> Not being able to resolve the name member of the led device structure
> to a
> meaningful value leads to confusion during ad-hoc debugging and
> potential
> breakage in the future, if we ever decide to access the name member
> outside of
> the registration function. Move the buffer to our private per led
> device
> structures so that it is accessible after registration.
> 
> A quick grep didn't yield any occurence of using the led device name
> parameter
> outside of the led device registration function, so currently we
> should already
> be safe for normal operation.
> 
> Signed-off-by: Sven Wegener <sven.wegener@...aler.net>
> Cc: Richard Purdie <rpurdie@...ys.net>

Acked-by: Zhu Yi <yi.zhu@...el.com>

Thanks,
-yi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/