linux-kernel - Re: nfsd, v4: oops in find_acceptable_alias, ppc32 Linux, post-2.6.27-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Aug 2008 14:08:07 +1000
From:	Neil Brown <neilb@...e.de>
To:	Paul Collins <paul@...ly.ondioline.org>
Cc:	"J. Bruce Fields" <bfields@...ldses.org>, linuxppc-dev@...abs.org,
	nfsv4@...ux-nfs.org, linux-kernel@...r.kernel.org
Subject: Re: nfsd, v4: oops in find_acceptable_alias, ppc32 Linux, post-2.6.27-rc1

On Monday August 4, paul@...ly.ondioline.org wrote:
> Neil Brown <neilb@...e.de> writes:
> >
> > What filesystem is being exported here?
> 
> Boring old ext3 (on LVM, on dm-crypt).

Good.  That makes it easier.
> 
> > Can you get an assembly version of exportfs_decode_fh, so we can check
> > what is happening at 0xa8 (and 0x4c).
> 

Thanks.

bctrl appears to be the indirect-function-call opcode.  There are
three of them one each for
  ->fh_to_dentry
  acceptable
  ->fh_to_parent

0xa8 is 'acceptable'.

In the first traceback, the crash was a call from very early in 
find_acceptable_alias,  The first significant thing it does is call
the 'acceptable' function.

So it seems clear that 'acceptable' is NULL.
It is equally clear that we never ever set it to NULL in the code.
The logical conclusion is "compiler error".
We can confirm (hopefully) by looking at a disassembly of fh_verify.

Maybe because nfsd_acceptable is 'static' and never explicitly called,
gcc gets confused and optimises it away.  Maybe a disassembly of 
nfsd_acceptable would be informative ... particularly if it turns out
to be empty.

Could you try removing the 'static' declaration for nfsd_acceptable
and recompile?
Or maybe try a different compiler?

Thanks,
NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/