linux-kernel - Re: [PATCH] ocfs2/cluster/netdebug.c: fix warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 Aug 2008 13:29:48 -0700
From:	Joel Becker <Joel.Becker@...cle.com>
To:	Alexander Beregalov <a.beregalov@...il.com>
Cc:	mfasheh@...e.com, ocfs2-devel@....oracle.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ocfs2/cluster/netdebug.c: fix warning

On Wed, Aug 06, 2008 at 12:10:36AM +0400, Alexander Beregalov wrote:
> From: Alexander Beregalov <a.beregalov@...il.com>
> 
> ocfs2/cluster/netdebug.c: fix warning
> 
> fs/ocfs2/cluster/netdebug.c:154: warning: format '%lu' expects
> 	type 'long unsigned int', but argument 17 has type 'suseconds_t'
>
> Signed-off-by: Alexander Beregalov <a.beregalov@...il.com>
> ---
> 
>  fs/ocfs2/cluster/netdebug.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/ocfs2/cluster/netdebug.c b/fs/ocfs2/cluster/netdebug.c
> index d8bfa0e..cdc0ed2 100644
> --- a/fs/ocfs2/cluster/netdebug.c
> +++ b/fs/ocfs2/cluster/netdebug.c
> @@ -151,7 +151,7 @@ static int nst_seq_show(struct seq_file *seq, void *v)
>  			   nst->st_send_time.tv_sec,
>  			   (unsigned long)nst->st_send_time.tv_usec,
>  			   nst->st_status_time.tv_sec,
> -			   nst->st_status_time.tv_usec);
> +			   (unsigned long)nst->st_status_time.tv_usec);

	suseconds_t is a signed long.  Can you change the format to %ld
and cast to long?  Unfortunately, we need the cast, as sparc64 and
parisc treat it as int.

Joel


-- 

"If you are ever in doubt as to whether or not to kiss a pretty girl, 
 give her the benefit of the doubt"
                                        -Thomas Carlyle

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@...cle.com
Phone: (650) 506-8127
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/