linux-kernel - [PATCH] x86: fix comment in protected mode header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 06 Aug 2008 15:25:26 +0200
From:	Philipp Kohlbecher <xt28@....de>
To:	"H. Peter Anvin" <hpa@...or.com>
CC:	linux-kernel@...r.kernel.org, trivial@...nel.org
Subject: [PATCH] x86: fix comment in protected mode header

From: Philipp Kohlbecher <xt28@....de>

Comments in arch/x86/boot/compressed/head_32.S erroneously refer to the 
real mode pointer as the second and the heap area as the third argument 
to decompress_kernel(). In fact, these have been the first and second 
argument, respectively, since v2.6.20.

This patch corrects the comments. It introduces no code changes.

Signed-off-by: Philipp Kohlbecher <xt28@....de>

---

Please CC me, I am not on the list.

  arch/x86/boot/compressed/head_32.S |    5 +++--
  1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/x86/boot/compressed/head_32.S 
b/arch/x86/boot/compressed/head_32.S
index ba7736c..29c5fbf 100644
--- a/arch/x86/boot/compressed/head_32.S
+++ b/arch/x86/boot/compressed/head_32.S
@@ -137,14 +137,15 @@ relocated:
   */
  	movl output_len(%ebx), %eax
  	pushl %eax
+			# push arguments for decompress_kernel:
  	pushl %ebp	# output address
  	movl input_len(%ebx), %eax
  	pushl %eax	# input_len
  	leal input_data(%ebx), %eax
  	pushl %eax	# input_data
  	leal boot_heap(%ebx), %eax
-	pushl %eax	# heap area as third argument
+	pushl %eax	# heap area
-	pushl %esi	# real mode pointer as second arg
+	pushl %esi	# real mode pointer
  	call decompress_kernel
  	addl $20, %esp
  	popl %ecx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/