linux-kernel - Re: [PATCH 4/2] ide-{floppy,tape}: remove request stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 6 Aug 2008 21:38:26 +0200
From:	Borislav Petkov <petkovbb@...glemail.com>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/2] ide-{floppy,tape}: remove request stack

On Wed, Aug 06, 2008 at 08:33:24PM +0200, Bartlomiej Zolnierkiewicz wrote:
> On Wed, Aug 6, 2008 at 7:14 PM, Bartlomiej Zolnierkiewicz
> <bzolnier@...il.com> wrote:
> 
> [...]
> 
> > ---
> > pc stack can also be removed with a bit of care, we just need sth like:
> >
> > - add request_sense_pc (request_sense_rq alike)
> >
> > - dynamically allocate pc-s for blk_{fs,pc}_request() in ide-floppy.c
> >  and for REQ_IDETAPE_{READ,WRITE} in ide-tape.c
> >
> > - add PC_FLAG_DYN for dynamically allocated pc-s
> >
> > - (the difficult part) figure out where to put freeing of dynamic pc-s
> >
> > Borislav, AFAIR you had some patches doing dynamic pc/rq-s?
> > Maybe it would be possible to dust off just their rq-parts?
> 
> Please disregard above comments -- I found a better way to deal with rq stack.

Looks good so far, even slimmer than the dynamic alloc ones i'd done. Will test
with ide-floppy on the weekend.

-- 
Regards/Gruss,
    Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/