linux-kernel - Re: [PATCH] bootup: Add built-in kernel command line for x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 06 Aug 2008 16:02:54 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Matt Mackall <mpm@...enic.com>
CC:	Tim Bird <tim.bird@...sony.com>,
	Robert Schwebel <r.schwebel@...gutronix.de>,
	linux kernel <linux-kernel@...r.kernel.org>,
	linux-embedded <linux-embedded@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] bootup: Add built-in kernel command line for x86

Matt Mackall wrote:
> On Wed, 2008-08-06 at 15:48 -0700, H. Peter Anvin wrote:
>> Tim Bird wrote:
>>> One difficulty is that the other arches' command lines
>>> are not currently "broken", so there's no real incentive
>>> to change them.
>>>
>>> The only thing novel thing I'm adding here is the addition of
>>> the leading '!' to allow for an override.  This is needed
>>> in some x86 cases I'm familiar with, but I've haven't seen
>>> any cases where it would be useful for other arches.
>>> (not to say they don't exist - I just haven't seen them.)
>>>
>> Note that it could just as easily be done with a CONFIG_CMDLINE_OVERRIDE 
>> option, since the initial reason for a magic character was to be able to 
>> provide both prefix and suffix splicing.
> 
> You're right, I had forgotten about the suffix splicing and my brain is
> a bit foggy on what motivated it.
> 

Well, prefix = bootloader overrides; suffix = builtin overrides.

>> CONFIG_CMDLINE_OVERRIDE is probably more palatable to other architectures.
> 
> Yes, though I doubt we're in danger of introducing any real backwards
> compatibility issues with the magic '!' at the beginning.

Well, it does if we want to make this a generic feature, which I believe 
we should.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/