linux-kernel - RE: [PATCH?] atl1e: WAKE_MCAST 2x. 1st WAKE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 8 Aug 2008 09:25:09 +0800
From:	Jie Yang <Jie.Yang@...eros.com>
To:	roel kluin <roel.kluin@...il.com>,
	"jgarzik@...hat.com" <jgarzik@...hat.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH?] atl1e: WAKE_MCAST 2x. 1st WAKE_UCAST?

On Friday, August 08, 2008 12:25 AM
roel kluin <roel.kluin@...il.com> wrote:
> untested, is it right?
> ---
> WAKE_MCAST bit tested twice, test WAKE_UCAST first.
>
> Signed-off-by: Roel Kluin <roel.kluin@...il.com> diff --git
> a/drivers/net/atl1e/atl1e_ethtool.c
> b/drivers/net/atl1e/atl1e_ethtool.c
> index cdc3b85..619c658 100644
> --- a/drivers/net/atl1e/atl1e_ethtool.c
> +++ b/drivers/net/atl1e/atl1e_ethtool.c
> @@ -355,7 +355,7 @@ static int atl1e_set_wol(struct
> net_device *netdev, struct ethtool_wolinfo *wol)
>         struct atl1e_adapter *adapter = netdev_priv(netdev);
>
>         if (wol->wolopts & (WAKE_ARP | WAKE_MAGICSECURE |
> -                           WAKE_MCAST | WAKE_BCAST | WAKE_MCAST))
> +                           WAKE_UCAST | WAKE_MCAST | WAKE_BCAST))
>                 return -EOPNOTSUPP;
>         /* these settings will always override what we
> currently have */
>         adapter->wol = 0;
>

Yes, It should be this! Thanks!

Best wishes
jie
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/