linux-kernel - Re: [PATCH -next] drm: sis depends on FB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 8 Aug 2008 03:11:03 +0100 (IST)
From:	Dave Airlie <airlied@...ux.ie>
To:	Randy Dunlap <randy.dunlap@...cle.com>
cc:	lkml <linux-kernel@...r.kernel.org>,
	akpm <akpm@...ux-foundation.org>
Subject: Re: [PATCH -next] drm: sis depends on FB_SIS


> > If someone asks for sisfb then sis drm uses code from it, if they don't 
> > ask for it it doesn't. So I want sisfb to be built in if its selected and 
> > sis drm is built-in.
> 
> config DRM_SIS
> 	select FB_SIS

Maybe the other way around, I don't want DRM_SIS influencing whether 
FB_SIS is on or off, if the user wants sisfb on, then when they select it, 
DRM_SIS should be built in the same way. But if sisfb isn't selected by 
the user, then selecting DRM_SIS shouldn't enable it.

Dave.

 > 
> might do it.
> 
> > Maybe I should just rip the dependency out completely, but this patch will 
> > break stuff badly, if someone was using the SIS DRM without sisfb.
> > 
> > Dave.
> > 
> >  > ---
> > >  drivers/gpu/drm/Kconfig |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > --- linux-next-20080806.orig/drivers/gpu/drm/Kconfig
> > > +++ linux-next-20080806/drivers/gpu/drm/Kconfig
> > > @@ -86,7 +86,7 @@ config DRM_MGA
> > >  
> > >  config DRM_SIS
> > >  	tristate "SiS video cards"
> > > -	depends on DRM && AGP
> > > +	depends on DRM && AGP && FB_SIS
> > >  	help
> > >  	  Choose this option if you have a SiS 630 or compatible video
> > >            chipset. If M is selected the module will be called sis. AGP
> 
> ---
> ~Randy
> Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
> http://linuxplumbersconf.org/
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/