linux-kernel - [PATCH] cgroup.c: remove goto statement from cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Aug 2008 15:25:51 +0600
From:	"Rakib Mullick" <rakib.mullick@...il.com>
To:	"Paul Menage" <menage@...gle.com>, "Paul Jackson" <pj@....com>
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] cgroup.c: remove goto statement from cgroup_init.

Hello everyone, following patch removes the use of goto statement.
Actually, we don't need it. Beacuse, if "err < 0", then it will never
be TRUE. So, we can skip the goto statement and can just return.
Thanks.

Signed-off-by: Rakib Mullick (rakib.mullick@...il.com)

--- linux-2.6.27-rc2.orig/kernel/cgroup.c	2008-08-11 15:16:49.000000000 +0600
+++ linux-2.6.27-rc2/kernel/cgroup.c	2008-08-11 15:16:26.000000000 +0600
@@ -2562,11 +2562,10 @@ int __init cgroup_init(void)

 	err = register_filesystem(&cgroup_fs_type);
 	if (err < 0)
-		goto out;
+		return err;

 	proc_create("cgroups", 0, NULL, &proc_cgroupstats_operations);

-out:
 	if (err)
 		bdi_destroy(&cgroup_backing_dev_info);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/