linux-kernel - Re: [PATCH 2/3][reiser4] don't leave loop prematurely

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 12 Aug 2008 16:54:38 +0400
From:	Edward Shishkin <edward.shishkin@...il.com>
To:	Ryan Hope <rmh3093@...il.com>
CC:	LKML <linux-kernel@...r.kernel.org>,
	Reiserfs mailing list <reiserfs-devel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 2/3][reiser4] don't leave loop prematurely

Ryan Hope wrote:
> This was item #9 on the todo list for reiser4 inclusion in mainline:
>
> diff --git
> a/52d76fde71070a6c4c8c581dd2bfe3c6ffa82ad7:fs/reiser4/page_cache.c
> b/7f1ee1bb0c5a2948f5347646795afd088da30eaf:fs/reiser4/page_cache.c
> index
> edf0911dc8bb61398374ecf4f849aa30753fb274..fe713681b73d2a6c4214f5938f21794573d8607d
> 100644
> --- a/52d76fde71070a6c4c8c581dd2bfe3c6ffa82ad7:fs/reiser4/page_cache.c
> +++ b/7f1ee1bb0c5a2948f5347646795afd088da30eaf:fs/reiser4/page_cache.c
> @@ -658,8 +658,7 @@ truncate_jnodes_range(struct inode *inode, pgoff_t
> from, pgoff_t count)
>                  unhash_unformatted_jnode(node);
>                  truncated_jnodes++;
>                  jput(node);
> -            } else
> -                break;
> +            }

No, this is wrong:
if (node == NULL), then there is nothing to do in this loop.

Edward.

>          }
>          if (i != taken || taken == 0)
>              break;
>
>
> -Ryan
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/