linux-kernel - Re: [PATCH] crypto: use kernel-provided bitops, unaligned access helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 17 Aug 2008 21:59:19 +1000
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux Crypto Mailing List <linux-crypto@...r.kernel.org>
Subject: Re: [PATCH] crypto: use kernel-provided bitops, unaligned access helpers

On Fri, Jul 04, 2008 at 07:43:15PM +0800, Herbert Xu wrote:
> On Thu, Jul 03, 2008 at 02:03:57PM -0700, Harvey Harrison wrote:
> > Remove the private implementation of 32-bit rotation and unaligned
> > access with byteswapping.
> > 
> > As a bonus, fixes sparse warnings:
> > crypto/camellia.c:602:2: warning: cast to restricted __be32
> > crypto/camellia.c:603:2: warning: cast to restricted __be32
> > crypto/camellia.c:604:2: warning: cast to restricted __be32
> > crypto/camellia.c:605:2: warning: cast to restricted __be32
> > crypto/camellia.c:710:2: warning: cast to restricted __be32
> > crypto/camellia.c:711:2: warning: cast to restricted __be32
> > crypto/camellia.c:712:2: warning: cast to restricted __be32
> > crypto/camellia.c:713:2: warning: cast to restricted __be32
> > crypto/camellia.c:714:2: warning: cast to restricted __be32
> > crypto/camellia.c:715:2: warning: cast to restricted __be32
> > crypto/camellia.c:716:2: warning: cast to restricted __be32
> > crypto/camellia.c:717:2: warning: cast to restricted __be32
> > 
> > Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
> 
> Patch applied.  BTW, this driver should perhaps use align mask
> instead rather than handling unaligned data on its own.

Hmm, camellia is now failing the tcrypt self-test.  Harvey,
could you have a look at this?

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/