linux-kernel - Re: [PATCH] Fix i486 suspend to disk CR4 oops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Aug 2008 00:04:19 +0200
From:	Pavel Machek <pavel@...e.cz>
To:	David Fries <david@...es.net>
Cc:	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: [PATCH] Fix i486 suspend to disk CR4 oops

On Mon 2008-08-18 07:58:03, David Fries wrote:
> On Mon, Aug 18, 2008 at 05:14:50AM +0100, Maciej W. Rozycki wrote:
> > On Sun, 17 Aug 2008, David Fries wrote:
> > > +	/* cr4 was introduced in the Pentium CPU */
> > 
> >  NACK.  Later i486 chips do have CR4 -- for PSE, VME, etc. (the set of
> > features varies across the line).  Use a fixup as elsewhere or something.

> 
> That's what I get for reading the Intel instruction set reference,
> "The CR4 register was added to the Intel Architecture beginning with
> the Pentium processor."
> 
> Ingo Molnar, thanks, I'll try the read_cr4_safe() version tonight (the
> computer is in the trunk of my car and I'm about ready to head to
> work).
> 
> In light of the above, how about updating the comments
> -       /* cr4 was introduced in the Pentium CPU */
> -       jecxz   1f      # cr4 Pentium and higher, skip if zero
> +       /* cr4 not in i386 only some i486, skip if zero */
> +       jecxz   1f      # cr4 not in i386 only some i486, skip if zero

Okay, can it happen that that cr4 is zero legitimately? If newer 486SX
chips support cr4 but not coprocessor...?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/