linux-kernel - [PATCH] KVM_GUEST: use the right parameter type on kvm_release_pt() (was Re: i386 allmodconfig in linux-next)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Aug 2008 16:16:07 -0300
From:	Eduardo Habkost <ehabkost@...hat.com>
To:	Avi Kivity <avi@...ranet.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org
Subject: [PATCH] KVM_GUEST: use the right parameter type on
	kvm_release_pt() (was Re: i386 allmodconfig in linux-next)

On Tue, Aug 19, 2008 at 04:41:41PM +0300, Avi Kivity wrote:
> Andrew Morton wrote:
>> arch/x86/kernel/kvm.c: In function 'paravirt_ops_setup':
>> arch/x86/kernel/kvm.c:233: warning: assignment from incompatible pointer type
>> arch/x86/kernel/kvm.c:234: warning: assignment from incompatible pointer type
>> arch/x86/kernel/kvm.c:235: warning: assignment from incompatible pointer type
>>   
>
> Eduardo, this is your
>
>> commit fa24f8e67c189b8b904c8a34f12e6dae9c14dbba
>> Author: Eduardo Habkost <ehabkost@...hat.com>
>> Date:   Wed Jul 30 18:32:27 2008 -0300
>>
>>     x86, paravirt_ops: use unsigned long instead of u32 for alloc_p*()  
>> pfn args
>
> Please compile-test (and run-test?) paravirt_ops changes with  
> CONFIG_KVM_GUEST and CONFIG_KVM_CLOCK enabled.  Thanks.
>

Oops, sorry. I've grepped for 'alloc_p*' and didn't notice KVM was using
release_p*. I've checked for binary code changes with all paravirt guest
options enabled, but missed the compiler warnings. Fix below.

---
From: Eduardo Habkost <ehabkost@...hat.com>
Subject: [PATCH] KVM_GUEST: Use the right parameter type on kvm_release_pt()

This fixes the following compiler warnings, that were introduced by me
on commit fa24f8e67c189b8b904c8a34f12e6dae9c14dbba.

arch/x86/kernel/kvm.c: In function 'paravirt_ops_setup':
arch/x86/kernel/kvm.c:233: warning: assignment from incompatible pointer type
arch/x86/kernel/kvm.c:234: warning: assignment from incompatible pointer type
arch/x86/kernel/kvm.c:235: warning: assignment from incompatible pointer type

Signed-off-by: Eduardo Habkost <ehabkost@...hat.com>
---
 arch/x86/kernel/kvm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
index 8b7a3cf..478bca9 100644
--- a/arch/x86/kernel/kvm.c
+++ b/arch/x86/kernel/kvm.c
@@ -178,7 +178,7 @@ static void kvm_flush_tlb(void)
 	kvm_deferred_mmu_op(&ftlb, sizeof ftlb);
 }
 
-static void kvm_release_pt(u32 pfn)
+static void kvm_release_pt(unsigned long pfn)
 {
 	struct kvm_mmu_op_release_pt rpt = {
 		.header.op = KVM_MMU_OP_RELEASE_PT,
-- 
1.5.5.GIT

-- 
Eduardo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/