linux-kernel - Re: [patch] fix intr-remap with dyn_array/nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 19 Aug 2008 12:40:21 -0700
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	"Suresh Siddha" <suresh.b.siddha@...el.com>
Cc:	mingo@...e.hu, linux-kernel@...r.kernel.org, ebiederm@...ssion.com,
	x86@...nel.org
Subject: Re: [patch] fix intr-remap with dyn_array/nr_irqs changes

On Tue, Aug 19, 2008 at 11:54 AM, Suresh Siddha
<suresh.b.siddha@...el.com> wrote:
> I didn't find time to closely review the dyn_array/nr_irqs changes. But
> the appended patch is needed to fix the broken intr-remapping support on
> x86/tip
>
> And also, I don't see any locks used in to_irq_desc_with_new(). How are
> we handling the concurrent usage scenarios. And also, this code can use
> some cleanups (like the names, to_irq_desc_with_new()?) etc.
>
> thanks,
> suresh
> ---
>
> In irq_2_iommu_with_new() and set_irte_irq(), irq_desc or
> irq_2_iommu pointers may not be allocated. So use the routines which
> will allocate them if they are not already allocated.
>
> Signed-off-by: Suresh Siddha <suresh.b.siddha@...el.com>

i'm trying to rebase sparseirq to tip/x86/core.

will address your concern about lock after that.

Thanks

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/