linux-kernel - [PATCH] kernel: fix dynamic printk sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 19 Aug 2008 14:50:18 -0700
From:	Harvey Harrison <harvey.harrison@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Jason Baron <jbaron@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] kernel: fix dynamic printk sparse warnings

ret is a common variable name and creates scads of shadowed variable
warnings.  Change to using __ret inside the dynamic_debug_enabled
macro.

Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
---
 include/linux/dynamic_printk.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/linux/dynamic_printk.h b/include/linux/dynamic_printk.h
index c54cf84..2d528d0 100644
--- a/include/linux/dynamic_printk.h
+++ b/include/linux/dynamic_printk.h
@@ -37,12 +37,12 @@ extern int __dynamic_dbg_enabled_helper(char *modname, int type,
 					int value, int hash);
 
 #define __dynamic_dbg_enabled(module, type, value, level, hash)  ({	     \
-	int ret = 0;							     \
+	int __ret = 0;							     \
 	if (unlikely((dynamic_printk_enabled & (1LL << DEBUG_HASH)) &&	     \
 			(dynamic_printk_enabled2 & (1LL << DEBUG_HASH2))))   \
-			ret = __dynamic_dbg_enabled_helper(module, type,     \
+			__ret = __dynamic_dbg_enabled_helper(module, type,   \
 								value, hash);\
-	ret; })
+	__ret; })
 
 #define dynamic_pr_debug(fmt, ...) do {					    \
 	static char mod_name[]						    \
-- 
1.6.0.274.g8aacc



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/