linux-kernel - [PATCH] pcmcia: fix uninitialized variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 19 Aug 2008 17:23:46 -0700
From:	Harvey Harrison <harvey.harrison@...il.com>
To:	Dominik Brodowski <linux@...do.de>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] pcmcia: fix uninitialized variable warning

drivers/pcmcia/pcmcia_resource.c: In function ‘pcmcia_map_mem_page’:
drivers/pcmcia/pcmcia_resource.c:255: warning: ‘s’ is used uninitialized in this function

Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
---
 drivers/pcmcia/pcmcia_resource.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/pcmcia/pcmcia_resource.c b/drivers/pcmcia/pcmcia_resource.c
index 717a466..190b8bb 100644
--- a/drivers/pcmcia/pcmcia_resource.c
+++ b/drivers/pcmcia/pcmcia_resource.c
@@ -251,11 +251,11 @@ int pcmcia_map_mem_page(window_handle_t win, memreq_t *req)
 	struct pcmcia_socket *s;
 	if ((win == NULL) || (win->magic != WINDOW_MAGIC))
 		return -EINVAL;
+	s = win->sock;
 	if (req->Page != 0) {
 		ds_dbg(s, 0, "failure: requested page is zero\n");
 		return -EINVAL;
 	}
-	s = win->sock;
 	win->ctl.card_start = req->CardOffset;
 	if (s->ops->set_mem_map(s, &win->ctl) != 0) {
 		ds_dbg(s, 0, "failed to set_mem_map\n");
-- 
1.6.0.274.g8aacc



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/