linux-kernel - Re: [PATCH RESEND] sound: make OSS sound core optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Aug 2008 11:37:44 +0200
From:	Tejun Heo <tj@...nel.org>
To:	Takashi Iwai <tiwai@...e.de>
CC:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	alsa-devel@...a-project.org, perex@...ex.cz
Subject: Re: [PATCH RESEND] sound: make OSS sound core optional

Hello,

Takashi Iwai wrote:
>> +config SOUND_OSS_CORE
>> +	bool
>> +	default n
>> +
>>  source "sound/oss/dmasound/Kconfig"
> 
> This seems missing from the scope.
> But, I think this should be rather in the block "if SOUND_PRIME" below.

SOUND_OSS_CORE should be turned on if ALSA OSS emul is turned on or
arch-um hostsound is turned on, both of which can be enabled regardless
of SOUND_PRIME, no?

>> --- work.orig/sound/sound_core.c
>> +++ work/sound/sound_core.c
> (snip)
>> +MODULE_ALIAS_CHARDEV_MAJOR(SOUND_MAJOR);
> 
> This alias should be in #ifdef CONFIG_SOUND_OSS_CORE.
> The module doesn't provide that major without CONFIG_SOUND_OSS_CORE.

Ah.. right.  Moving.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/