linux-kernel - Re: USB Serial device disconnect causes IRQ disable after using ehci controller halted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Aug 2008 10:53:25 -0700
From:	Greg KH <greg@...ah.com>
To:	David Brownell <david-b@...bell.net>
Cc:	amruth_pv@...oo.com, Alan Stern <stern@...land.harvard.edu>,
	Karsten Wiese <fzu@...gehoertderstaat.de>,
	Oliver Neukum <oliver@...kum.org>,
	USB list <linux-usb@...r.kernel.org>,
	Kernel development list <linux-kernel@...r.kernel.org>
Subject: Re: USB Serial device disconnect causes IRQ disable after using
	ehci controller halted

On Tue, Aug 26, 2008 at 11:35:04PM -0700, David Brownell wrote:
> On Tuesday 26 August 2008, amruth wrote:
> > This patch below does not fix the issue it just stops IRQ being
> > disabled but still ehci hcd crashes. 
> 
> That patch was only intended to address the issue of bogus error
> handling.
> 
> 
> > Please let me know what could be causing the issue.
> 
> If it's like the other case, I'd hope this patch would solve it.
> 
> Note that you also seem to be having hardware or firmware issues
> with the peripheral you're connecting ... this won't change that
> stuff at all.
> 
> - Dave
> 
> ================ SNIP!
> From: David Brownell <dbrownell@...rs.sourceforge.net>
> 
> As noted by Stefan Neis <Stefan.Neis@...il.com>, we had a recent
> regression with EHCI periodic transfers, in some (seemingly not
> all that common) cases.
> 
> The root cause was that the schedule activation was only loosely
> coupled to the addition or removal of transfers, so two different 
> execution contexts could both think they had to deactivate (or
> conversely activate) the schedule.  So this fix tightens that
> coupling, managing it more like a refcount.
> 
> Signed-off-by: David Brownell <dbrownell@...rs.sourceforge.net>

Do you want me to also apply this one?  If so, for .27 or .28?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/